Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-7850] _DataStorage's set(_:) method should use storeBytes(of:toByteOffset:as:) #3687

Open
hamishknight opened this issue Jun 2, 2018 · 0 comments

Comments

@hamishknight
Copy link

Previous ID SR-7850
Radar None
Original Reporter @hamishknight
Type Bug
Additional Detail from JIRA
Votes 0
Component/s Foundation
Labels Bug
Assignee None
Priority Medium

md5: c7b57e6b7c36a5f0a52076e6c5231d17

relates to:

  • SR-7849 DataStorage's get(:) method should use load(fromByteOffset:as:)
  • SR-7726 Data.withUnsafe(Mutable)Bytes should use bindMemory(to:) instead of assumingMemoryBound(to:)

Issue Description:

Currently _DataStorage's set(_:) method uses assumingMemoryBound(to:), which can invoke undefined behaviour if the underlying memory is bound to a type unrelated to UInt8.

We should use storeBytes(of:toByteOffset:as:) instead.

For more context, see https://forums.swift.org/t/how-to-use-data-withunsafebytes-in-a-well-defined-manner/12811.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant