[SR-7863] corelibs-foundation build system doesn't respect assertions flag #3683
Comments
|
Comment by Gregor Milos (Grzegorz Miłoś) (JIRA) I reviewed the logic that controls whether backtraces are printed. Key test is done here: @inlinable // FIXME(sil-serialize-all)
@_transparent
internal
func _fatalErrorFlags() -> UInt32 {
// The current flags are:
// (1 << 0): Report backtrace on fatal error
#if os(iOS) || os(tvOS) || os(watchOS)
return 0
#else
return _isDebugAssertConfiguration() ? 1 : 0
#endif
}
@inlinable // FIXME(sil-serialize-all)
@_transparent
public // @testable
func _isDebugAssertConfiguration() -> Bool {
// The values for the assert_configuration call are:
// 0: Debug
// 1: Release
// 2: Fast
return Int32(Builtin.assert_configuration()) == 0
}
the logic is implemented here: // Parse the assert configuration identifier.
if (const Arg *A = Args.getLastArg(OPT_AssertConfig)) {
StringRef Configuration = A->getValue();
if (Configuration == "DisableReplacement") {
Opts.AssertConfig = SILOptions::DisableReplacement;
} else if (Configuration == "Debug") {
Opts.AssertConfig = SILOptions::Debug;
} else if (Configuration == "Release") {
Opts.AssertConfig = SILOptions::Release;
} else if (Configuration == "Unchecked") {
Opts.AssertConfig = SILOptions::Unchecked;
} else {
Diags.diagnose(SourceLoc(), diag::error_invalid_arg_value,
A->getAsString(Args), A->getValue());
return true;
}
} else if (FEOpts.ParseStdlib) {
// Disable assertion configuration replacement when we build the standard
// library.
Opts.AssertConfig = SILOptions::DisableReplacement;
} else if (Opts.AssertConfig == SILOptions::Debug) {
// Set the assert configuration according to the optimization level if it
// has not been set by the -Ounchecked flag.
Opts.AssertConfig =
(IRGenOpts.shouldOptimize() ? SILOptions::Release : SILOptions::Debug);
}To summarise, there are three flags that control assert_configuration: |
Attachment: Download
Additional Detail from JIRA
md5: d033feae658f0a47f72a9c6f6189edef
Issue Description:
Most projects in the swift build respect
assertionsoption passed tobuild-script:https://github.com/apple/swift/blob/master/utils/build_swift/driver_arguments.py#L606-L662
corelibs-foundation does not.
One of the effects is that
fatalError-s in Foundation don't contain stack-traces, making them more difficult to diagnose.I'm attaching an example reproduction in the form of SwiftPM package:
In comparison
fatalErrorin the executable itself (build in Debug mode, which enables assertions) gives:Which can be symbolicated as follows:
The text was updated successfully, but these errors were encountered: