Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-7912] Upstream package depending on #if SWIFT_PACKAGE breaks in Xcode 10 #4792

Closed
stephencelis opened this issue Jun 7, 2018 · 1 comment
Labels

Comments

@stephencelis
Copy link
Contributor

Previous ID SR-7912
Radar rdar://problem/41168357
Original Reporter @stephencelis
Type Bug
Status Resolved
Resolution Duplicate
Environment

WWDC Xcode 10, Swift 4.2

Additional Detail from JIRA
Votes 0
Component/s Package Manager
Labels Bug
Assignee None
Priority Medium

md5: 45ca8977615abc8ba404269902398184

duplicates:

  • SR-7965 Xcode Project generated by SwiftPM 4.2 can't build when package depends on Yams

Issue Description:

We started trying to upgrade the Point-Free repo (https://github.com/pointfreeco/pointfreeco) to Xcode 10 and Swift 4.2 but hit some snags using SPM.

Swiftx (https://github.com/typelift/Swiftx) uses #if SWIFT_PACKAGE to handle their own upstream import of Operadics (https://github.com/typelift/Operadics). I filed a bug with them documenting steps to reproduce here: typelift/Swiftx#73

Per convo with @aciidb0mb3r on Slack, this may be a regression in SPM.

Recap:

  1. Use xcode-select with the Xcode 10 beta

  2. Use swift package generate-xcodeproj with a project that depends on Swiftx, e.g. https://github.com/bkase/DoctorPretty

  3. Try to build said project

This seems to fail because import Operadics, guarded behind #if SWIFT_PACKAGE, doesn't execute.

@ankitspd
Copy link
Member

@swift-ci create

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 4, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants