New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SR-8012] Remove Indexable
aliases
#50545
Comments
Comment by Franz Busch (JIRA) I wanted to take this as my first issue as it seems pretty quick to fix. I already located the files and the test I need to change. Sadly, I can't run the tests as the build script with --validation-tests fails with:
Any idea what I can do about that? |
I do not know about the specific error there, but there are tests that check for the typealiases. If you remove the typealiases, you also need to remove the tests. Look for example:
|
Comment by Franz Busch (JIRA) I already removed these. I guess I just got problems actually compiling swift at the moment |
Comment by Franz Busch (JIRA) Opened a PR: #17625 |
So CodaFi (JIRA User), the bug here was about completely removing the type aliases (originally described to be removed for swift 4), where as a4230ab keeps them around with "obsoleted 5.0" inside comments... So has this bug become invalid, or? |
You mean IndexDistance, right? That's a separate thing. #17580 knocks this one out in particular, you can file another bug about that one if you want to start a discussion about removing it. |
CodaFi (JIRA User), this is in stdlib/public/core/MigrationSupport.swift (latest master) :
However, the explanation might come from the PR description: But there seems to be a problem with obsoleting type aliases that needs digging into that is crashing SILGen, so some are commented out for now. |
Additional Detail from JIRA
md5: b5e7fd07f09fbc5621ab6dd30428c1f8
Issue Description:
All the
Indexable
type aliases state that they'll be removed in Swift 4. Now that we're on 4.2 and on our way toward 5, we should be able to remove those aliases.The text was updated successfully, but these errors were encountered: