Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-8099] Nest all swift auxiliary files similar to the object files #4783

Closed
weissi opened this issue Jun 25, 2018 · 8 comments
Closed

[SR-8099] Nest all swift auxiliary files similar to the object files #4783

weissi opened this issue Jun 25, 2018 · 8 comments
Labels

Comments

@weissi
Copy link
Member

weissi commented Jun 25, 2018

Previous ID SR-8099
Radar rdar://problem/41060279
Original Reporter @weissi
Type Bug
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s llbuild, Package Manager
Labels Bug
Assignee None
Priority Medium

md5: 0768b263acc4cc8ccd6b18ab32bc6918

is duplicated by:

  • SR-8618 Swiftc crash compiling SwiftObjects

Issue Description:

compiler crash

Compile Swift Module 'WOShowcaseApp' (15 sources)
<unknown>:0: error: fatal error encountered while reading from module 'WOShowcaseApp'; please file a bug report with your project and the crash log

*** DESERIALIZATION FAILURE (please include this section in any bug report) ***
(see "While..." info below)
0  swift                    0x000000010773867a PrintStackTraceSignalHandler(void*) + 42
1  swift                    0x0000000107737a86 SignalHandler(int) + 966
2  libsystem_platform.dylib 0x00007fff70763d9a _sigtramp + 26
3  libsystem_platform.dylib 0x00007ffeec28aba0 _sigtramp + 2075291168
4  libsystem_c.dylib        0x00007fff7061e189 abort + 127
5  swift                    0x0000000104bd52eb swift::ModuleFile::fatal(llvm::Error) + 1915
6  swift                    0x0000000104bf96ce swift::SILDeserializer::readSILFunction(llvm::PointerEmbeddedInt<unsigned int, 31>, swift::SILFunction*, llvm::StringRef, bool, bool) + 7678
7  swift                    0x0000000104c0ef7d swift::SILDeserializer::getAllSILFunctions() + 893
8  swift                    0x0000000104cb84ba swift::SerializedSILLoader::getAllForModule(swift::Identifier, swift::FileUnit*) + 170
9  swift                    0x00000001039fc20e performCompile(swift::CompilerInstance&, swift::CompilerInvocation&, llvm::ArrayRef<char const*>, int&, swift::FrontendObserver*, swift::UnifiedStatsReporter*) + 34590
10 swift                    0x00000001039f05f5 swift::performFrontend(llvm::ArrayRef<char const*>, char const*, void*, swift::FrontendObserver*) + 7733
11 swift                    0x0000000103999c28 main + 13144
12 libdyld.dylib            0x00007fff70561ee1 start + 1
Stack dump:
0.  Program arguments: /Applications/Xcode-new.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/swift -frontend -merge-modules -emit-module /private/tmp/SwiftObjects/SwiftObjects/.build/x86_64-apple-macosx10.10/debug/WOShowcaseApp.build/Application~partial.swiftmodule /private/tmp/SwiftObjects/SwiftObjects/.build/x86_64-apple-macosx10.10/debug/WOShowcaseApp.build/ComponentBindingInfo~partial.swiftmodule /private/tmp/SwiftObjects/SwiftObjects/.build/x86_64-apple-macosx10.10/debug/WOShowcaseApp.build/CowCard~partial.swiftmodule /private/tmp/SwiftObjects/SwiftObjects/.build/x86_64-apple-macosx10.10/debug/WOShowcaseApp.build/DemoWOForm~partial.swiftmodule /private/tmp/SwiftObjects/SwiftObjects/.build/x86_64-apple-macosx10.10/debug/WOShowcaseApp.build/DemoWOHyperlink~partial.swiftmodule /private/tmp/SwiftObjects/SwiftObjects/.build/x86_64-apple-macosx10.10/debug/WOShowcaseApp.build/DemoWORepetition~partial.swiftmodule /private/tmp/SwiftObjects/SwiftObjects/.build/x86_64-apple-macosx10.10/debug/WOShowcaseApp.build/DemoWOString~partial.swiftmodule /private/tmp/SwiftObjects/SwiftObjects/.build/x86_64-apple-macosx10.10/debug/WOShowcaseApp.build/DynamicElementSample~partial.swiftmodule /private/tmp/SwiftObjects/SwiftObjects/.build/x86_64-apple-macosx10.10/debug/WOShowcaseApp.build/Frame~partial.swiftmodule /private/tmp/SwiftObjects/SwiftObjects/.build/x86_64-apple-macosx10.10/debug/WOShowcaseApp.build/Main~partial.swiftmodule /private/tmp/SwiftObjects/SwiftObjects/.build/x86_64-apple-macosx10.10/debug/WOShowcaseApp.build/Context~partial.swiftmodule /private/tmp/SwiftObjects/SwiftObjects/.build/x86_64-apple-macosx10.10/debug/WOShowcaseApp.build/CowModel~partial.swiftmodule /private/tmp/SwiftObjects/SwiftObjects/.build/x86_64-apple-macosx10.10/debug/WOShowcaseApp.build/DirectAction~partial.swiftmodule /private/tmp/SwiftObjects/SwiftObjects/.build/x86_64-apple-macosx10.10/debug/WOShowcaseApp.build/Session~partial.swiftmodule /private/tmp/SwiftObjects/SwiftObjects/.build/x86_64-apple-macosx10.10/debug/WOShowcaseApp.build/main~partial.swiftmodule -parse-as-library -sil-merge-partial-modules -disable-diagnostic-passes -disable-sil-perf-optzns -target x86_64-apple-macosx10.10 -enable-objc-interop -sdk /Applications/Xcode-new.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk -I /private/tmp/SwiftObjects/SwiftObjects/.build/x86_64-apple-macosx10.10/debug -I /private/tmp/SwiftObjects/SwiftObjects/.build/checkouts/swift-nio.git-6502700480489875831/Sources/CNIOZlib/include -I /private/tmp/SwiftObjects/SwiftObjects/.build/checkouts/swift-nio.git-6502700480489875831/Sources/CNIOHTTPParser/include -I /private/tmp/SwiftObjects/SwiftObjects/.build/checkouts/swift-nio.git-6502700480489875831/Sources/CNIOSHA1/include -I /private/tmp/SwiftObjects/SwiftObjects/.build/checkouts/swift-nio.git-6502700480489875831/Sources/CNIOAtomics/include -I /private/tmp/SwiftObjects/SwiftObjects/.build/checkouts/swift-nio.git-6502700480489875831/Sources/CNIODarwin/include -I /private/tmp/SwiftObjects/SwiftObjects/.build/checkouts/swift-nio.git-6502700480489875831/Sources/CNIOLinux/include -F /Applications/Xcode-new.app/Contents/Developer/Platforms/MacOSX.platform/Developer/Library/Frameworks -enable-testing -g -module-cache-path /private/tmp/SwiftObjects/SwiftObjects/.build/x86_64-apple-macosx10.10/debug/ModuleCache -swift-version 4 -Onone -D SWIFT_PACKAGE -D DEBUG -color-diagnostics -Xcc -fmodule-map-file=/private/tmp/SwiftObjects/SwiftObjects/.build/x86_64-apple-macosx10.10/debug/CNIOZlib.build/module.modulemap -Xcc -fmodule-map-file=/private/tmp/SwiftObjects/SwiftObjects/.build/x86_64-apple-macosx10.10/debug/CNIOHTTPParser.build/module.modulemap -Xcc -fmodule-map-file=/private/tmp/SwiftObjects/SwiftObjects/.build/x86_64-apple-macosx10.10/debug/CNIOSHA1.build/module.modulemap -Xcc -fmodule-map-file=/private/tmp/SwiftObjects/SwiftObjects/.build/x86_64-apple-macosx10.10/debug/CNIOAtomics.build/module.modulemap -Xcc -fmodule-map-file=/private/tmp/SwiftObjects/SwiftObjects/.build/x86_64-apple-macosx10.10/debug/CNIODarwin.build/module.modulemap -Xcc -fmodule-map-file=/private/tmp/SwiftObjects/SwiftObjects/.build/x86_64-apple-macosx10.10/debug/CNIOLinux.build/module.modulemap -Xcc -fmodule-map-file=/private/tmp/SwiftObjects/SwiftObjects/.build/checkouts/swift-nio-zlib-support.git--6898465682700177690/module.modulemap -emit-module-doc-path /private/tmp/SwiftObjects/SwiftObjects/.build/x86_64-apple-macosx10.10/debug/WOShowcaseApp.swiftdoc -module-name WOShowcaseApp -o /private/tmp/SwiftObjects/SwiftObjects/.build/x86_64-apple-macosx10.10/debug/WOShowcaseApp.swiftmodule 
1.  While deserializing SIL function "$S13WOShowcaseApp4MainC5demosSaySSGvm"
<unknown>:0: error: unable to execute command: Abort trap: 6
<unknown>:0: error: merge-module command failed due to signal 6 (use -v to see invocation)
error: terminated(1): /Applications/Xcode-new.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/swift-build-tool -f /private/tmp/SwiftObjects/SwiftObjects/.build/debug.yaml main output:

repro

git clone git@github.com:SwiftObjects/SwiftObjects.git && cd SwiftObjects && git reset --hard 5495da3f60b00ec8e7eeaab90d893a4b1ecad2b6 && swift build

environment

$ swift -version
Apple Swift version 4.2 (swiftlang-1000.0.24 clang-1000.10.28.1)
Target: x86_64-apple-darwin18.0.0
@weissi
Copy link
Member Author

weissi commented Jun 25, 2018

@swift-ci create

@belkadan
Copy link

This is a materializeForSet for a rather boring variable,

class Main : WOComponent {
  // …  
  public var demo : String? = nil
  // …
}

The deserialization code is complaining that the function type doesn't match up, but both types dump as this:

(sil_function_type type=@convention(method) (Builtin.RawPointer, @inout Builtin.UnsafeValueBuffer, @guaranteed Main) -> (Builtin.RawPointer, Optional<Builtin.RawPointer>))

@rjmccall, any ideas?

@belkadan
Copy link

Removing the public makes everything happy. Hm.

@rjmccall
Copy link
Member

SILFunctionTypes are always canonical and I don't think we hide anything when printing them, so the mostly likely thing is that the nominal component type (Main) is actually a different type for some reason.

@belkadan
Copy link

belkadan commented Jul 3, 2018

Aha, this module has both a Main.swift and a main.swift, which would be fine…except that SwiftPM accidentally puts the intermediates for those two in the same place on a case-insensitive filesystem. @aciidb0mb3r, you have the dup for this, right?

@belkadan
Copy link

belkadan commented Jul 3, 2018

(There is a separate "the compiler shouldn't crash" aspect, but short of noticing that we're reading the same file even though we went through two different paths, I'm not sure how to catch this in any meaningful way.)

@ankitspd
Copy link
Member

ankitspd commented Jul 3, 2018

Got a radar but not JIRA: <rdar://problem/41060279> Nest all swift auxiliary files similar to the object files

@ankitspd
Copy link
Member

apple/swift-llbuild#356

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 4, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants