New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SR-8104] Crashes related to enums in Xcode 9.3.1 #50636
Comments
@swift-ci create |
Any chance you can post the declaration of the TableSection enum, even if anonymized somewhat? |
Comment by Michael McGuire (JIRA) @belkadan Would it be possible to send it to you privately? That shouldn't be a problem. |
Sure. Does https://bugreport.apple.com count? That'll limit it to Apple people, at least, and we can leave it connected to this JIRA bug. |
Comment by Michael McGuire (JIRA) Perfect! I'll create it and post the Radar here |
Comment by Michael McGuire (JIRA) rdar://problem/41587337 |
Thanks for the radar! I've been looking into a similar crasher and I wonder if it might be the same thing. Would it be possible to post a full crash log (or several, if possible) for these crashes? Or barring that, just the exception info, VM region info, and register states? Feel free to attach them to the radar if you want to keep them private. |
Comment by Michael McGuire (JIRA) Absolutely @mikeash. I've copied out every single crash we've received via iTunes Connect that looks anything similar to this, zipped it up and attached to the Radar. |
How delightfully comprehensive. This definitely looks a lot like the other bug I've been poking at. Unfortunately I haven't actually figured out the fix yet, but it's good to have more examples, and there are some differences in here which may be informative. Anyway, I'll keep at it. |
Comment by Michael McGuire (JIRA) Great! Hopefully it wasn't too much 🙂 |
There's no such thing as too many crash logs. |
I've finally tracked this down. Here's the PR for the fix: #17879 That was a nasty one. Thanks again for your diagnostic info. It was useful to know that the problem went beyond what I was originally examining, and the differences in your crashes did have some hints on what was happening. |
Comment by Michael McGuire (JIRA) Awesome @mikeash! Is there anyway we can get this fix into |
But of course! #17880 |
Comment by Michael McGuire (JIRA) @mikeash amazing, thank you! thinking back I guess I could have tried that myself 😃 |
Comment by Michael McGuire (JIRA) An update: we are not seeing this crash anymore after upgrading to Xcode 10.0 with Swift 4.2! Unfortunately our app has become nearly unusable on 32-bit devices. See: https://bugs.swift.org/browse/SR-9256 |
Ouch! I'll take a look at that one too. |
Environment
Xcode 9.3
Build version 9E145
Additional Detail from JIRA
md5: 2aed21fd5b191aacaa7ea9f76e02068f
Issue Description:
After building our app using Xcode 9.3.1, we've started receiving a small, but noticeable amount of crashes around code that seemed to work previously. The crashes are occurring inside of
swift_storeEnumTagSinglePayload
andswift_getEnumCaseSinglePayload
. Searching around I found SR-7743 (which appears to be crashing in a similar place, so we tried disabling optimizations for our latest deployment. That did not seem to fix the issue.I don't know if these crashes are the same bug but since they started at the same time after upgrading, I'm including them. Note that the names of some of the modules, types and functions needed to be changed before posting here:
The text was updated successfully, but these errors were encountered: