Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-8252] Consolidate and Fix -debug-crash-* Flags #50784

Open
CodaFi opened this issue Jul 13, 2018 · 2 comments
Open

[SR-8252] Consolidate and Fix -debug-crash-* Flags #50784

CodaFi opened this issue Jul 13, 2018 · 2 comments
Labels
compiler The Swift compiler in itself good first issue Good for newcomers improvement

Comments

@CodaFi
Copy link
Member

CodaFi commented Jul 13, 2018

Previous ID SR-8252
Radar None
Original Reporter @CodaFi
Type Improvement
Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Improvement, StarterBug
Assignee None
Priority Medium

md5: 85fb82c2ea0303f5308473609b79bde5

Issue Description:

Currently, Swift has -debug-crash-immediately and -debug-crash-after-parse and -debug-assert-after-parse. The problem is twofold:

1) -debug-assert-after-parse understands the old hat meaning of "-parse" which used to mean "parse and type check". Now that the compiler understands these are distinct actions, this flag is misnamed.

2) The more useful distinction is crashing immediately versus crashing after a particular phase.

We should generalize -debug-assert and -debug-crash to mean "assert after the current frontend action finishes" or "crash after the current frontend action finishes" respectively. -debug-crash-immediately should still be retained because there needs to be a way to crash argument parsing.

@CodaFi
Copy link
Member Author

CodaFi commented Jul 13, 2018

@belkadan Do you think this would make a good starter bug?

@belkadan
Copy link
Contributor

Sure, that makes sense. Good to have a pool of those available.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler The Swift compiler in itself good first issue Good for newcomers improvement
Projects
None yet
Development

No branches or pull requests

2 participants