Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-8449] swift-corelibs-foundation: URLRequest/NSURLRequest don't hash correctly #3653

Open
lorentey opened this issue Aug 2, 2018 · 1 comment
Open

[SR-8449] swift-corelibs-foundation: URLRequest/NSURLRequest don't hash correctly #3653

lorentey opened this issue Aug 2, 2018 · 1 comment
Assignees
@lorentey
Labels
bug Foundation

Comments

@lorentey
Copy link
Member

lorentey commented Aug 2, 2018

Previous ID SR-8449
Radar None
Original Reporter @lorentey
Type Bug
Status In Progress
Resolution
Additional Detail from JIRA
Votes 0
Component/s Foundation
Labels Bug
Assignee @lorentey
Priority Medium

md5: 3fa3d4f99969c6d6129900fb0e168590

Issue Description:

NSURLRequest inherits hash from NSObject, but overrides isEqual: to compare contents. This also breaks hashing for URLRequest, which calls into NSURLRequest.hash.
@lorentey
Copy link
Member Author

lorentey commented Aug 2, 2018

PR with fix is at #1646

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lorentey lorentey

Labels
bug Foundation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lorentey