For module references note that SourceEntityWalker::visitModuleReference() exists as callback but IndexSwiftASTWalker is not overriding it to take advantage of it.

Comment by Bruno Rocha (JIRA)

@akyrtzi Thanks! I got it to work:

    {
      key.kind: source.lang.swift.ref.module,
      key.name: "Swift",
      key.line: 7,
      key.column: 13
    },

Is there anything else I can add to it to make it feel more like an "index"? I thought about providing an USR, but since all USR generation seems to work on top of ValueDecls I wanted to be sure if this is possible in first place.

For reference: rockbruno@cde8d3d

How is this dumped from `swift-ide-test -print-indexed-symbols` ? Checkout test cases in `test/Index` to see how to add a test case for this.

I think we also need to define a USR for it. Try opening a PR so we can iterate on it.

Comment by Bruno Rocha (JIRA)

It returns an empty string unfortunately:

1:8 | module/Swift | Swift | | Ref | rel: 0

Comment by Bruno Rocha (JIRA)

Managed to generate an USR to them. #19243

Comment by Bruno Rocha (JIRA)

@akyrtzi What do you think?

Clang has similar need, index module references with an associated USR. That will allow us to index the same module references across Swift and Objective-C, using the same USR.
Basically, give me some time, I'll introduce some APIs on the clang side to create a USR for a module, and you'll then be able to use them for the Swift side as well.

Comment by Bruno Rocha (JIRA)

Sounds good.

PR has been merged.