Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-8741] Include CFFileDescriptor in public CoreFoundation source drop #3638

Open
swift-ci opened this issue Sep 13, 2018 · 7 comments
Open

Comments

@swift-ci
Copy link
Contributor

Previous ID SR-8741
Radar None
Original Reporter copumpkin (JIRA User)
Type Improvement
Additional Detail from JIRA
Votes 0
Component/s Foundation
Labels Improvement
Assignee None
Priority Medium

md5: 804e07814a9beb51f8360c9f5ac98c49

is duplicated by:

  • SR-6136 foundation project should include CFFileDescriptor header

Issue Description:

The current source seems to jump through some hoops to avoid including it with the REAL_FILE_SCHEDULING preprocessor define and I was wondering if it could just be included in the public repo, since Apple's stance on stuff like this seems to have loosened a bit since the CFLite days.

The reason for this is that I've seen at least a few public projects (https://github.com/facebook/watchman probably the most popular/visible of them that affects me) that use those APIs and we currently have to jump through a bunch of hoops to support them.

Of course, not having seen the actual source I might be missing good reasons to leave it out, but if it was just an oversight I'd love to see it included.

cc @parkera @millenomi who have been involved before with earlier issues like this

@parkera
Copy link
Member

parkera commented Sep 13, 2018

The exclusion was really only about the lack of libdispatch support in the previous CFLite stuff. There is not much reason to continue to exclude it since we now have the ability to call dispatch_source API.

@parkera
Copy link
Member

parkera commented Sep 13, 2018

rdar://problem/44425528

@swift-ci
Copy link
Contributor Author

Comment by Dan Peebles (JIRA)

@parkera cool, so it's likely to appear at some point? I can't see the radar link; is that someone else asking for this in the past or just some internal tracking of this request of mine?

Is it also appropriate to ask for other similar omissions from CF on this tracker? This one seemed like the most likely to get traction but there are a couple of others that are still missing

@parkera
Copy link
Member

parkera commented Sep 13, 2018

That’s a radar I just filed for you to track this for us internally (a copy of this report). It’ll help us not to lose your request.

If you have more requests, you can file them here. Please CC Lily and I as you did here so we get a notification.

@swift-ci
Copy link
Contributor Author

Comment by Dan Peebles (JIRA)

Great, I'll do that, and thank you so much!

@parkera
Copy link
Member

parkera commented Sep 13, 2018

No problem, and thank you for the contributions to the project.

@swift-ci
Copy link
Contributor Author

Comment by Dan Peebles (JIRA)

Marking the other as a duplicate because this one has made more progress, even though it happened later (and I forgot that the earlier one existed, even though I commented on it a couple of years ago 😛)

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants