Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-8744] Add three missing classes to public CoreFoundation codebase #3637

Open
swift-ci opened this issue Sep 13, 2018 · 5 comments
Open

[SR-8744] Add three missing classes to public CoreFoundation codebase #3637

swift-ci opened this issue Sep 13, 2018 · 5 comments
Labels
Foundation Improvement

Comments

@swift-ci
Copy link
Contributor

Previous ID SR-8744
Radar None
Original Reporter copumpkin (JIRA User)
Type Improvement
Additional Detail from JIRA
Votes 0
Component/s Foundation
Labels Improvement
Assignee None
Priority Medium

md5: 7612f7bfd152482e884917b89a588e76

Issue Description:

In addition to CFFileDescriptor, which I requested in SR-8741, I've noticed three other missing classes in the public source drop. Since I don't know the reason for their omission, it's perfectly understandable if the answer to this is "sorry we can't release those" but I figured I'd ask 🙂

Here are the missing ones I'm noticing based solely on diffing the official CoreFoundation.h from the public repository (note that although the diffs are bigger than this, some of the missing #includes just haven't been added to CoreFoundation.h yet, but the files are in the repository; see #1691 for example):

  • CFURLEnumerator

  • CFFileSecurity

  • CFStringTokenizer

cc @parkera @millenomi
@parkera
Copy link
Member

parkera commented Sep 14, 2018

These particular classes are almost entirely based on functionality which is actually not part of CF itself, so they may be difficult to port. We can keep around this request but it's less likely to happen than the one in SR-8741.

@swift-ci
Copy link
Contributor Author

Comment by Dan Peebles (JIRA)

Yeah, that makes sense. I had a hunch these were a bit less likely than the other one 🙂

@swift-ci
Copy link
Contributor Author

Comment by Dan Peebles (JIRA)

If I had to pick a priority for these though, from highest to lowest, I think it would be:

  1. CFURLEnumerator

  2. CFStringTokenizer

  3. CFFileSecurity

This is mostly just based on informal perception of how widespread they are and how many things depend on things that depend on them. CFURLEnumerator for example is used by QT, which a lot of stuff depends on, so I care about it more 🙂

@swift-ci
Copy link
Contributor Author

Comment by Dan Peebles (JIRA)

@parkera also, please let me know if would improve the likelihood of seeing any one of these if I create separate issues for each 🙂 I don't want someone willing to help seeing me ask for <easy thing> and <hard thing> at the same time and getting put off by <hard thing>

@parkera
Copy link
Member

parkera commented Sep 18, 2018

We can keep one bug for now, but make it clear here that we'll accept partial progress.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Foundation Improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@parkera @swift-ci