Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-8822] the current implementation of the pkgconfig whitelist is not self-explanatory #4892

Open
swift-ci opened this issue Sep 23, 2018 · 1 comment
Labels

Comments

@swift-ci
Copy link
Contributor

Previous ID SR-8822
Radar None
Original Reporter codekitchen (JIRA User)
Type Bug
Environment

MacOS 10.13.6

Xcode 10.0
Build version 10A255

Swift Package Manager - Swift 4.2.0 (106115d)

Additional Detail from JIRA
Votes 1
Component/s Package Manager
Labels Bug
Assignee None
Priority Medium

md5: 291555e970f9ba58919a5ec3c5bd19fd

Issue Description:

Recently swift-build was fixed so that this warning is properly printed out:

'sdl2' sdl2.pc: warning: non whitelisted flag(s): -D_THREAD_SAFE

However, I do not think that this is sufficient. To me, since this is just a warning and compilation continues, my first assumption was that this individual flag was ignored, but all the other flags from pkgconfig were retained. I eventually had to build SPM myself and add some debug print statements to figure out that my build was failing because this warning means that all flags from the pkgconfig were dropped, for both building and linking.

For my use case, I'd prefer if the behavior was to just print the warning, drop those specific flags, and retain the rest of the pkgconfig flags. But if that's not an option, this warning should be made more clear about the fact that all flags have been dropped, not just these specific flags, or perhaps compilation should just be halted.

(The fact that this flag isn't whitelisted is a separate issue already tracked in SR-7689).

@swift-ci
Copy link
Contributor Author

Comment by Pop Flamingo (JIRA)

I encountered the same issue and did a PR to try to fix it : #1827

Don't hesitate to comment it if you have any feedback.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants