Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-8870] _builtinWordValue should zext/sext based on signedness #51376

Closed
milseman mannequin opened this issue Sep 27, 2018 · 2 comments
Closed

[SR-8870] _builtinWordValue should zext/sext based on signedness #51376

milseman mannequin opened this issue Sep 27, 2018 · 2 comments
Assignees
@moiseev
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. good first issue Good for newcomers standard library Area: Standard library umbrella

Comments

@milseman
Copy link
Mannequin

milseman mannequin commented Sep 27, 2018

Previous ID SR-8870
Radar rdar://problem/44835551
Original Reporter @milseman
Type Bug
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Standard Library
Labels Bug, StarterBug
Assignee @moiseev
Priority Medium

md5: 704c7bcbe00f04e1121a124c26f648ad

Issue Description:

The discussion from https://forums.swift.org/t/compiling-4-2-on-armv7/16267/38 is identifying potential issues when _builtinWordValue does not use the appropriate sign-preserving or sign-ignoring extension operation.

We should make a test case that repros on Darwin/CI, and apply a fix.
@milseman
Copy link
Mannequin Author

milseman mannequin commented Sep 27, 2018

@swift-ci create

@moiseev
Copy link
Mannequin

moiseev mannequin commented Oct 9, 2018

#19600 seems to have fixed it.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@moiseev moiseev

Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. good first issue Good for newcomers standard library Area: Standard library umbrella
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants