Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-9038] Swift Syntax requires the use of dynamic linking #442

Closed
swift-ci opened this issue Oct 18, 2018 · 5 comments
Closed

[SR-9038] Swift Syntax requires the use of dynamic linking #442

swift-ci opened this issue Oct 18, 2018 · 5 comments
Labels
bug Something isn't working

Comments

@swift-ci
Copy link
Contributor

Previous ID SR-9038
Radar None
Original Reporter tannernelson (JIRA User)
Type Bug
Additional Detail from JIRA
Votes 4
Component/s SwiftSyntax
Labels Bug
Assignee None
Priority Medium

md5: 9bbab7716cc05fa62a1f9472abf24ed4

Issue Description:

Currently Swift Syntax vends a dynamic product (https://github.com/apple/swift-syntax/blob/master/Package.swift#L8).

This creates issues when trying to link a static executable that uses Swift Syntax. Is there any way this could be changed to a normal product?
@swift-ci
Copy link
Contributor Author

Comment by tanner0101 (JIRA)

#19

@MaxDesiatov
Copy link
Member

As far as I understand, Swift Syntax still dynamically links to lib_InternalSwiftSyntaxParser.dylib on macOS, which leads to issues such as this SwiftDocOrg/swift-doc#197 It also probably links dynamically to a similar .so file on Linux?

@keith
Copy link
Collaborator

keith commented Feb 25, 2021

apple/swift#36151

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 9, 2022
@ahoppen
Copy link
Collaborator

ahoppen commented Jun 21, 2022

rdar://90554334

@CodaFi
Copy link
Member

CodaFi commented Sep 8, 2022

This is no longer true as of #616. You can now consume SwiftSyntax and the SwiftParser as static libraries without any superfluous dependencies.

@CodaFi CodaFi closed this as completed Sep 8, 2022
adevress pushed a commit to adevress/swift-syntax that referenced this issue Jan 14, 2024
@allevato
Merge pull request apple#442 from allevato/no-assignment-expr-rule
11d16d0 
Add a rule that prevents assignment from appearing in expression contexts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@MaxDesiatov @keith @CodaFi @shahmishal @ahoppen @swift-ci