Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-9117] LinkOnceODR functions need to be COMDAT'ed #51614

Closed
compnerd opened this issue Oct 29, 2018 · 1 comment
Closed

[SR-9117] LinkOnceODR functions need to be COMDAT'ed #51614

compnerd opened this issue Oct 29, 2018 · 1 comment
Assignees
Labels
compiler The Swift compiler in itself

Comments

@compnerd
Copy link
Collaborator

Previous ID SR-9117
Radar None
Original Reporter @compnerd
Type Sub-task
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Sub-task
Assignee @compnerd
Priority Medium

md5: d224c3c29fa9d7fb154cee38e2790ad8

Parent-Task:

Issue Description:

LLVM IR semantics have changed. We need to construct a COMDAT group for the LinkOnceODR functions. This will prevent multiple symbol definitions on COFF. It also will be an improvement for ELF targets reducing binary size.

@compnerd
Copy link
Collaborator Author

#20059 should address this.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler The Swift compiler in itself
Projects
None yet
Development

No branches or pull requests

1 participant