Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-9129] move installed libraries to architecture subdirectory #51626

Open
compnerd opened this issue Oct 29, 2018 · 4 comments
Open

[SR-9129] move installed libraries to architecture subdirectory #51626

compnerd opened this issue Oct 29, 2018 · 4 comments
Labels
Android Platform: Android compiler The Swift compiler in itself good first issue Good for newcomers Linux Platform: Linux standard library Area: Standard library umbrella task toolchain

Comments

@compnerd
Copy link
Collaborator

Previous ID SR-9129
Radar None
Original Reporter @compnerd
Type Task
Additional Detail from JIRA
Votes 0
Component/s Compiler, Project Infrastructure, Standard Library
Labels Task, Android, Linux, StarterBug, build
Assignee None
Priority Medium

md5: 9e1d4d406e122aeeb675d43067a2fdc4

Issue Description:

The current installation of the libraries in usr/lib/swift/<os> does not work for non-MachO targets. We need to move the libraries to usr/lib/swift/<os>/<arch> for ELF and PE/COFF targets.

@belkadan
Copy link
Contributor

I thought we landed this already? There was definitely a PR working on it.

@compnerd
Copy link
Collaborator Author

No, it isn't merged, there is still a few more patches left for that. Daniel Rodriguez was working on this.

@compnerd
Copy link
Collaborator Author

Removing this from the Windows set as the Windows support for this is more or less complete. In fact, we may wish to move back towards unarchitectured directories for the swift modules as they are multi-architecture friendly now.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@finagolfin
Copy link
Contributor

@compnerd, I implemented this in #63782 and associated pulls, but this approach was rejected in favor of using triple-named module directories instead, so you can close this issue now.

My recently-opened #63645 tracks the overarching issue of doing something about these Swift runtime libraries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Platform: Android compiler The Swift compiler in itself good first issue Good for newcomers Linux Platform: Linux standard library Area: Standard library umbrella task toolchain
Projects
None yet
Development

No branches or pull requests

4 participants