Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-9133] JUnit output format doesn't work if --parallel not selected #4752

Open
alblue opened this issue Oct 30, 2018 · 5 comments
Open

[SR-9133] JUnit output format doesn't work if --parallel not selected #4752

alblue opened this issue Oct 30, 2018 · 5 comments
Labels
bug

Comments

@alblue
Copy link
Contributor

alblue commented Oct 30, 2018

Previous ID SR-9133
Radar None
Original Reporter @alblue
Type Bug
Additional Detail from JIRA
Votes 0
Component/s Package Manager
Labels Bug, Screened
Assignee anayini (JIRA)
Priority Medium

md5: 7a7f61fc246593e1da18eec9acf288a5

Issue Description:

The JUnit output report should be printed regardless of the setting of --parallel.

Running:
swift test --xunit-output=/tmp/results.xml

doesn't generate a file at /tmp/results.xml.

Running:
swift test --xunit-output=/tmp/results.xml --parallel --num-workers=1

does generate a file at /tmp/results.xml
@swift-ci
Copy link
Contributor

swift-ci commented Jun 9, 2019

Comment by Arjun Nayini (JIRA)

@aciidb0mb3r - I picked up this ticket and started on it. I found that the `TestRunner` and `ParallelTestRunner` are actually separate `final class` types that aren't tied together by anything. I was thinking I could get this done but would want to refactor those types to adhere to a single protocol (refactor them to look alike) and then add in xunit output for the serial one. Currently it looks like the xunit generator class is just explicitly tied to the parallel test runner.

Does this seem like a reasonable approach here? Figured I would ping you since you have the latest commits in that area of the code.

@swift-ci
Copy link
Contributor

swift-ci commented Jun 9, 2019

Comment by Arjun Nayini (JIRA)

Actually I need to think about this a bit more. Seems like perhaps a SerialTestRunner type might make things a bit more clear with both ParallelTestRunner and SerialTestRunner encapsulating some set of TestRunners.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 4, 2022
@Samasaur1
Copy link

Any news on this?

@jd-sandk
Copy link

jd-sandk commented Aug 25, 2022 •
edited

It would be nice if this feature/option (--xunit-output) worked as expected, can something please be done to fix this issue.

@michalszelagsonos
Copy link

Bump for this issue. We're about to enter 2024, would be great to get something as foundational as this fixed. Note, this kind of report is very important for CI and observability integrations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@alblue @tomerd @swift-ci @Samasaur1 @michalszelagsonos @jd-sandk