Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-9138] correct DLL Storage on SIL for multifile CUs #51634

Open
compnerd opened this issue Oct 30, 2018 · 3 comments
Open

[SR-9138] correct DLL Storage on SIL for multifile CUs #51634

compnerd opened this issue Oct 30, 2018 · 3 comments
Assignees
@compnerd
Labels
CodeGen compiler The Swift compiler in itself improvement IRGen LLVM IR generation Windows Platform: Windows

Comments

@compnerd
Copy link
Collaborator

Previous ID SR-9138
Radar None
Original Reporter @compnerd
Type Improvement
Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Improvement, CodeGen, IRGen, Windows
Assignee @compnerd
Priority Medium

md5: a3562a8f7e828cf66ef7c9ad95b33899

Issue Description:

When we do a SIL merge, we should pass over and ensure that we convert DLLImportStorageClass to DefaultStorageClass for locally defined functions.
@compnerd
Copy link
Collaborator Author

I think that I may have another idea on how to handle this. Currently we compute the DLL storage based on the target module. However, it may be possible to walk up the chain and if the module name is the same we could change the `dllimport` to local storage.

@compnerd
Copy link
Collaborator Author

compnerd commented Mar 9, 2020

#30292 should address the majority of the cases.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@compnerd
Copy link
Collaborator Author

#67406 corrects a good chunk of issues that arose when building SPM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@compnerd compnerd

Labels
CodeGen compiler The Swift compiler in itself improvement IRGen LLVM IR generation Windows Platform: Windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@compnerd