Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-917] Implement SE-0039: Modernizing Playground Literals #43529

Closed
lattner mannequin opened this issue Mar 10, 2016 · 8 comments
Closed

[SR-917] Implement SE-0039: Modernizing Playground Literals #43529

lattner mannequin opened this issue Mar 10, 2016 · 8 comments
Assignees
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself good first issue Good for newcomers

Comments

@lattner
Copy link
Mannequin

lattner mannequin commented Mar 10, 2016

Previous ID SR-917
Radar None
Original Reporter @lattner
Type Bug
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Bug, StarterBug
Assignee @tkremenek
Priority Medium

md5: a0bc2b56a3c6aea0083e82a07097a2d2

Issue Description:

SE-0039 has been accepted with modifications:
https://github.com/apple/swift-evolution/blob/master/proposals/0039-playgroundliterals.md

@lattner
Copy link
Mannequin Author

lattner mannequin commented Mar 10, 2016

@swift-ci
Copy link
Collaborator

Comment by Luc (JIRA)

I'll try to work on that for my first contribution to Swift.

@lattner
Copy link
Mannequin Author

lattner mannequin commented Mar 12, 2016

Fantastic!

@swift-ci
Copy link
Collaborator

Comment by Step Christopher (JIRA)

LFabien (JIRA User) I've started working on this, but I'm still learning my way around the compiler code and toolchains. Happy to coordinate. This is probably a very small job for those familiar with the innards of Swift, lit.py, etc - but it's going to take some figuring out for me. 🙂

I'll share as I have some commits on my branch.

@swift-ci
Copy link
Collaborator

Comment by Luc (JIRA)

Hi step (JIRA User) You started working on it first so I'll try to find another task 🙂 I didn't see your message at first so I've also started working on this (I renamed the different functions and I was fixing a few failing tests).

Let me know if you need help or if you stop working on it and I'll push my changes.

@swift-ci
Copy link
Collaborator

Comment by Step Christopher (JIRA)

Thanks, will do. There are lots of things marked as starter bugs it looks like, and a couple similar syntax changes. I'll definitely let you know if I get stuck though. So far I started by changing some tests to expect the new syntax, and figuring out the test and build infrastructure. Hoping to get a lot done this weekend.

@lattner
Copy link
Mannequin Author

lattner mannequin commented Apr 17, 2016

@tkremenek submitted a PR with an implementation of this here:
#2215

@tkremenek
Copy link
Member

Landed in `master`:

b8bbed8

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants