Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-9180] LLDB / Python 3.7 build issues (Fedora 29) #4618

Closed
swift-ci opened this issue Nov 5, 2018 · 5 comments
Closed

[SR-9180] LLDB / Python 3.7 build issues (Fedora 29) #4618

swift-ci opened this issue Nov 5, 2018 · 5 comments
Assignees
Labels
bug Something isn't working LLDB for Swift

Comments

@swift-ci
Copy link

swift-ci commented Nov 5, 2018

Previous ID SR-9180
Radar None
Original Reporter zwoop (JIRA User)
Type Bug
Status Resolved
Resolution Done

Attachment: Download

Additional Detail from JIRA
Votes 0
Component/s LLDB for Swift
Labels Bug
Assignee @belkadan
Priority Medium

md5: 27d0eb1135dd0c330fe48813574e2e43

Issue Description:

There's a tiny issue when compiling the Swift LLDB, with Python 3.7 on Fedora 29. A tiny possible fix is attached, but not sure what the preference here (changing the type, or this cast).

@swift-ci
Copy link
Author

swift-ci commented Nov 5, 2018

Comment by Leif Hedstrom (JIRA)

Another, cleaner option, would be to move the declaration of c into the #ifdef, and make it a const char* for Python 3.x.

@belkadan
Copy link

belkadan commented Nov 5, 2018

cc jingham@apple.com (JIRA User)

Since this problem isn't related to Swift, it's also probably best to submit the patch upstream to the "lldb-commits" list at llvm.org. You can see more details at https://lldb.llvm.org.

@swift-ci
Copy link
Author

swift-ci commented Nov 5, 2018

Comment by Leif Hedstrom (JIRA)

Looks like it was fixed upstream in LLVM already, sorry for the noise:

commit b032b915ad7eea93e06d571f1a3ca712cd203b9e
Author: Pavel Labath <labath@google.com>
AuthorDate: Wed Jul 25 11:35:28 2018 +0000
Commit: Pavel Labath <labath@google.com>
CommitDate: Wed Jul 25 11:35:28 2018 +0000

Fix PythonString::GetString for >=python-3.7

The return value of PyUnicode_AsUTF8AndSize is now "const char *".

Thanks to Brett Neumeier for testing the patch out on python 3.7.

git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@337908 91177308-0d34-0410-b5e6-96231b3b80d8

@belkadan
Copy link

belkadan commented Nov 5, 2018

Feel free to open a PR cherry-picking the fix from upstream-with-swift to the swift-5.0-branch, then.

@belkadan
Copy link

belkadan commented Nov 6, 2018

I ended up getting this: apple/swift-lldb#1037

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 7, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working LLDB for Swift
Projects
None yet
Development

No branches or pull requests

2 participants