Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-9270] Tweak String comparison inlinability #51747

Closed
milseman mannequin opened this issue Nov 15, 2018 · 1 comment
Closed

[SR-9270] Tweak String comparison inlinability #51747

milseman mannequin opened this issue Nov 15, 2018 · 1 comment
Assignees
@milseman
Labels
standard library Area: Standard library umbrella

Comments

@milseman
Copy link
Mannequin

milseman mannequin commented Nov 15, 2018

Previous ID SR-9270
Radar None
Original Reporter @milseman
Type Sub-task
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Standard Library
Labels Sub-task
Assignee @milseman
Priority Medium

md5: 4110eab7bbc295adeab246b7fb2fd3f4

Parent-Task:

Issue Description:

Many benchmark regressions seems to be primarily related to what portions of small-string comparison is inlinable and small-string fast paths (such as in-register comparison). We need to tweak the dispatch pattern. Known-affected benchmarks:

  • Chars2

  • SubstringComparable

  • Calculator
@milseman
Copy link
Mannequin Author

milseman mannequin commented Dec 6, 2018

This was fixed or greatly alleviated in #21024

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@milseman milseman

Labels
standard library Area: Standard library umbrella
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants