Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-931] Make SwiftPM Path.relative(to:) solid #5311

Closed
mxcl opened this issue Mar 13, 2016 · 2 comments
Closed

[SR-931] Make SwiftPM Path.relative(to:) solid #5311

mxcl opened this issue Mar 13, 2016 · 2 comments
Labels
bug

Comments

@mxcl
Copy link
Contributor

mxcl commented Mar 13, 2016

Previous ID SR-931
Radar None
Original Reporter @mxcl
Type Bug
Status Closed
Resolution Duplicate
Additional Detail from JIRA
Votes 0
Component/s Package Manager
Labels Bug, StarterBug
Assignee None
Priority Medium

md5: faccfda05555b17e7644f117f8411244

relates to:

  • SR-1005 SwiftPM port to Foundation

Issue Description:

The SwiftPM relative path functions are not completely reliable.

We need to ensure we handle all edge cases like parsing `..` beyond the root directory, and that the behavior in such situations is either sensible, or we make this function throw.

A thorough implementation here would include extensive tests.

I suggest referring to other implementations in scripting languages like Python and Ruby for a reference.
@mxcl
Copy link
Contributor Author

mxcl commented Mar 16, 2016

Or use Foundation.

@mxcl
Copy link
Contributor Author

mxcl commented Mar 21, 2016

Closing and instead opening a ticket to port us to Foundation.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 4, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mxcl