Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-9414] Swift benchmarks: exit with an error if the stdlib is built with asserts. #51879

Open
eeckstein opened this issue Dec 5, 2018 · 1 comment
Open

[SR-9414] Swift benchmarks: exit with an error if the stdlib is built with asserts. #51879

eeckstein opened this issue Dec 5, 2018 · 1 comment
Labels
compiler The Swift compiler in itself improvement

Comments

@eeckstein
Copy link
Member

Previous ID SR-9414
Radar None
Original Reporter @eeckstein
Type Improvement
Additional Detail from JIRA
Votes 1
Component/s Compiler
Labels Improvement
Assignee None
Priority Medium

md5: df5925e15518545488e9fb177a83a6ac

Issue Description:

A stdlib assert build does not give meaningful results for benchmarks.

The benchmark driver should exit with an error if _isStdlibInternalChecksEnabled() returns true.

See discussion in https://forums.swift.org/t/building-with-stdlib-assertions-enabled-why
@stephentyrone
Copy link
Member

Instead of exiting with an error, we should run the benchmark but not report results.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler The Swift compiler in itself improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stephentyrone @eeckstein