Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-9428] [AD] Refactor AutoDiffParameterIndices #51892

Closed
rxwei opened this issue Dec 7, 2018 · 1 comment
Closed

[SR-9428] [AD] Refactor AutoDiffParameterIndices #51892

rxwei opened this issue Dec 7, 2018 · 1 comment
Assignees
@marcrasi
Labels
swift for tensorflow task

Comments

@rxwei
Copy link
Member

rxwei commented Dec 7, 2018

Previous ID SR-9428
Radar None
Original Reporter @rxwei
Type Task
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Swift for TensorFlow
Labels Task
Assignee @marcrasi
Priority Medium

md5: 98cea584d41dccf76a031fa2334708fc

Issue Description:

  • Make AutoDiffParameterIndices instances uniqued in ASTContext.

  • Remove mutating methods from AutoDiffParameterIndices.

  • Replace all occurrences of `const AutoDiffParameterIndices &` with `AutoDiffParameterIndices *` to follow surrounding conventions.

cc @marcrasi
@marcrasi
Copy link
Mannequin

marcrasi mannequin commented Dec 10, 2018

This is important for the SILDeclRef changes, so I will do it now.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcrasi marcrasi

Labels
swift for tensorflow task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rxwei