Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-9450] Warn if GroupInfo.json contains non-existent file #51913

Closed
benrimmington opened this issue Dec 9, 2018 · 0 comments
Closed

[SR-9450] Warn if GroupInfo.json contains non-existent file #51913

benrimmington opened this issue Dec 9, 2018 · 0 comments
Labels
compiler The Swift compiler in itself improvement serialization Area → compiler: Serialization & deserialization standard library Area: Standard library umbrella

Comments

@benrimmington
Copy link
Collaborator

Previous ID SR-9450
Radar None
Original Reporter @benrimmington
Type Improvement
Additional Detail from JIRA
Votes 0
Component/s Compiler, Standard Library
Labels Improvement, Serialization
Assignee None
Priority Medium

md5: 7b6cc147258ddebcd508cc5e352067db

Issue Description:

When a swift file is added to stdlib/public/core/, but the GroupInfo.json isn't updated, the build will fail with error: no group info found for file: '...'

However, when a swift file is removed, but the GroupInfo.json isn't updated, the build will succeed (without a warning or error). For example, see apple/swift#21118.

It might be possible to add something to serialization::writeDocToStream which checks that all of its group info has been used.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@benrimmington benrimmington closed this as not planned Won't fix, can't repro, duplicate, stale Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler The Swift compiler in itself improvement serialization Area → compiler: Serialization & deserialization standard library Area: Standard library umbrella
Projects
None yet
Development

No branches or pull requests

1 participant