Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-9455] extra-cmake-options are not forwarded to CoreFoundation build #3576

Open
kevints mannequin opened this issue Dec 10, 2018 · 2 comments
Open

[SR-9455] extra-cmake-options are not forwarded to CoreFoundation build #3576

kevints mannequin opened this issue Dec 10, 2018 · 2 comments

Comments

@kevints
Copy link
Mannequin

kevints mannequin commented Dec 10, 2018

Previous ID SR-9455
Radar None
Original Reporter @kevints
Type Bug
Additional Detail from JIRA
Votes 0
Component/s Foundation
Labels Bug, BuildScript, CMake
Assignee None
Priority Medium

md5: 04ea53c822f5035afa9614809d12ab0f

Issue Description:

When I invoke build-script with extra-cmake-options they are not forwarded to the CoreFoundation build. This is due to the use of ExternalProject_Add to build CoreFoundation rather than add_subdirectory. I could whitelist the flags I'm trying to pass through (CURL_LIBRARY AND CURL_INCLUDE_DIR) but there's a high risk there are other important flags controlling the CoreFoundation build. Using add_subdirectory instead would allow CoreFoundation and Foundation to share a cache, so that important build settings don't vary between them.

@kevints
Copy link
Mannequin Author

kevints mannequin commented Dec 10, 2018

CC @compnerd

@kevints
Copy link
Mannequin Author

kevints mannequin commented Dec 10, 2018

I've hacked up a branch that fixes this, I'll clean it up and put up a PR shortly.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

0 participants