Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-9466] Redo AssignInst lowering in DI #51928

Closed
slavapestov opened this issue Dec 10, 2018 · 5 comments
Closed

[SR-9466] Redo AssignInst lowering in DI #51928

slavapestov opened this issue Dec 10, 2018 · 5 comments
Assignees
@slavapestov
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself good first issue Good for newcomers SILGen Area → compiler: The SIL generation stage

Comments

@slavapestov
Copy link
Member

Previous ID SR-9466
Radar None
Original Reporter @slavapestov
Type Bug
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Bug, SILGen, StarterBug
Assignee @slavapestov
Priority Medium

md5: e1c8a6fadd6a566b95dae2f52adf2edc

Issue Description:

As a follow-up to #21160 we should change DI to not do AssignInst lowering itself.

Instead, amend AssignInst with an initialization kind, either Unknown, Init, Reinit or Assign. New AssignInsts emitted by SILGen begin as Unknown. DI sets them to Init, Reinit or Assign. Then the RawSILInstructionLowering pass rewrites them as follows:

  • Init becomes a StoreInst Init

  • Reinit becomes a LoadInst, DeallocRefInst, and StoreInst

  • Assign becomes a StoreInst Assign
@gottesmm
Copy link
Member

If anyone wants to do this as a starter bug. I am happy to mentor.

@swift-ci
Copy link
Collaborator

Comment by Mani Ramezan (JIRA)

@gottesmm I would love to : )

@Azoy
Copy link
Member

Azoy commented Jan 13, 2019

Mani (JIRA User) are you still working on this? I'd like to take a stab at this one if you don't mind.

@swift-ci
Copy link
Collaborator

Comment by Mani Ramezan (JIRA)

@Azoy I haven't started working on it, please feel free to assign it to yourself

@Azoy
Copy link
Member

Azoy commented Jan 13, 2019

#21827

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slavapestov slavapestov

Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself good first issue Good for newcomers SILGen Area → compiler: The SIL generation stage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@slavapestov @gottesmm @Azoy @swift-ci