Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-9476] [test] Move NSSlowString into StdlibUnittest #51938

Open
milseman mannequin opened this issue Dec 11, 2018 · 3 comments
Open

[SR-9476] [test] Move NSSlowString into StdlibUnittest #51938

milseman mannequin opened this issue Dec 11, 2018 · 3 comments
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. standard library Area: Standard library umbrella

Comments

@milseman
Copy link
Mannequin

milseman mannequin commented Dec 11, 2018

Previous ID SR-9476
Radar None
Original Reporter @milseman
Type Bug
Additional Detail from JIRA
Votes 0
Component/s Standard Library
Labels Bug
Assignee None
Priority Medium

md5: d212f96e504de8a39f4ecd49f1210bd1

Issue Description:

Rather than conditionally compile it in every test that might use it, move this and others into the test suite. We want to have:

  • NSContiguousASCIIString

  • NSContiguousUTF16String

  • NSNonContiguousString

as these are the 3 categories of lazily-bridged strings for the stdlib's perspective.
@milseman
Copy link
Mannequin Author

milseman mannequin commented Dec 12, 2018

We'd also like to have these types available for benchmarks as well. @palimondo, any thoughts on how to make a shared implementation that's available to both?

@palimondo
Copy link
Mannequin

palimondo mannequin commented Dec 13, 2018

Umm… nope. Doing magic with cmake build is @gottesmm's forte.

@milseman
Copy link
Mannequin Author

milseman mannequin commented Dec 13, 2018

@gottesmm, I have some code that I want to be shared between StdlibUnittest and the benchmark framework. In this bug, custom NSString subclasses for testing and benchmarking lazy bridging. Elsewhere, string workloads that are useful for both tests and performance. Any thoughts?

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. standard library Area: Standard library umbrella
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants