New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SR-9505] Source compatibility breakage in vapor-routing #3571
Comments
Likely caused by apple/swift#20225 |
cc @millenomi, @phausler |
We intend to offer that call as a first-class API on Data in master and it is no longer appropriate that downstream clients implement it unprefixed. @weissi how can we stage a transition from your category to the new API? |
cc @itaiferber |
@millenomi oh yes, of course. No idea why we made that extension public, apologies! |
@millenomi ok, made a pull request for NIO to a) rename our CC @Lukasa |
ah hang on, that's a public protocol... For now, I'll rename our method until we can get rid of the complete protocol. For NIO 1 thought we won't be able to fix as this is SemVer major. |
Yeah. we should coordinate because that could make the Swift where it lands incompatible with NIO 1. |
@millenomi agreed. |
Looks like this has been fixed by apple/swift#22074 I'm going to Un-XFAIL vapor project which is currently UPASS'ing. |
Additional Detail from JIRA
md5: b2f089832ff65d4f4d06c40289643089
Issue Description:
[16/16] /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/build/compat_macos/install/toolchain/usr/bin/swiftc -module-name Routing -incremental -emit-dependencies -emit-module -emit-module-path /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/vapor_routing/.build/x86_64-apple-macosx/release/Routing.swiftmodule -output-file-map /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/vapor_routing/.build/x86_64-apple-macosx/release/Routing.build/output-file-map.json -parse-as-library -whole-module-optimization -num-threads 4 -c /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/vapor_routing/Sources/Routing/Parameter/Parameter.swift /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/vapor_routing/Sources/Routing/Parameter/ParameterValue.swift /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/vapor_routing/Sources/Routing/Parameter/Parameters.swift /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/vapor_routing/Sources/Routing/Register/PathComponent.swift /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/vapor_routing/Sources/Routing/Register/Route.swift /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/vapor_routing/Sources/Routing/Register/RouterOption.swift /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/vapor_routing/Sources/Routing/Routing/RoutableComponent.swift /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/vapor_routing/Sources/Routing/Routing/RouterNode.swift /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/vapor_routing/Sources/Routing/Routing/TrieRouter.swift /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/vapor_routing/Sources/Routing/Utilities/Deprecated.swift /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/vapor_routing/Sources/Routing/Utilities/Exports.swift /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/vapor_routing/Sources/Routing/Utilities/RoutingError.swift -I /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/vapor_routing/.build/x86_64-apple-macosx/release -target x86_64-apple-macosx10.10 -swift-version 4 -sdk /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk -F /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/Library/Frameworks -O -j4 -DSWIFT_PACKAGE -Xcc -fmodule-map-file=/Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/vapor_routing/.build/x86_64-apple-macosx/release/CNIOSHA1.build/module.modulemap -I /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/vapor_routing/.build/checkouts/swift-nio-b68c973e/Sources/CNIOSHA1/include -Xcc -fmodule-map-file=/Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/vapor_routing/.build/x86_64-apple-macosx/release/CNIOAtomics.build/module.modulemap -I /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/vapor_routing/.build/checkouts/swift-nio-b68c973e/Sources/CNIOAtomics/include -Xcc -fmodule-map-file=/Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/vapor_routing/.build/x86_64-apple-macosx/release/CNIODarwin.build/module.modulemap -I /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/vapor_routing/.build/checkouts/swift-nio-b68c973e/Sources/CNIODarwin/include -Xcc -fmodule-map-file=/Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/vapor_routing/.build/x86_64-apple-macosx/release/CNIOLinux.build/module.modulemap -I /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/vapor_routing/.build/checkouts/swift-nio-b68c973e/Sources/CNIOLinux/include -Xcc -fmodule-map-file=/Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/vapor_routing/.build/checkouts/swift-nio-zlib-support-c4b8a10c/module.modulemap -module-cache-path /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/vapor_routing/.build/x86_64-apple-macosx/release/ModuleCache
/Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/vapor_routing/Sources/Routing/Routing/TrieRouter.swift:77:29: error: ambiguous use of 'withUnsafeBytes'
if constant.value.withUnsafeBytes({ path.routerCompare(to: $0, options: options) }) {
^
Foundation.Data:42:28: note: found this candidate
@inlinable public func withUnsafeBytes(_ body: (UnsafeRawBufferPointer) throws -> ResultType) rethrows -> ResultType
^
NIOFoundationCompat.Data:2:28: note: found this candidate
@inlinable public func withUnsafeBytes(_ body: (UnsafeRawBufferPointer) throws -> R) rethrows -> R
^
The text was updated successfully, but these errors were encountered: