Uploaded image for project: 'Swift'
  1. Swift
  2. SR-9551

Failure to run benchmarks with build-script

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Open
    • Priority: Medium
    • Resolution: Unresolved
    • Component/s: Compiler
    • Labels:

      Description

      Running benchmarks with build-script like this:
      swift-source $ ./swift/utils/build-script -R -B --no-assertions
      fails because the values for --independent-samples parameter are somehow not passed on here.

       

      Here's the tail of the full console output:

      [1/1] cd /Users/mondo/Developer/swift-source/build/Ninja-Release/swift-macosx-x86_64/...ipt /Users/mondo/Developer/swift-source/swift/benchmark/scripts/compare_perf_tests.p
      FAILED: benchmark/CMakeFiles/check-swift-benchmark-macosx-x86_64
      cd /Users/mondo/Developer/swift-source/build/Ninja-Release/swift-macosx-x86_64/benchmark && /Users/mondo/Developer/swift-source/build/Ninja-Release/swift-macosx-x86_64/bin/Benchmark_Driver run -o O --output-dir /Users/mondo/Developer/swift-source/build/Ninja-Release/swift-macosx-x86_64/benchmark/logs --swift-repo /Users/mondo/Developer/swift-source/swift --independent-samples  && /Users/mondo/Developer/swift-source/build/Ninja-Release/swift-macosx-x86_64/bin/Benchmark_Driver run -o Onone --output-dir /Users/mondo/Developer/swift-source/build/Ninja-Release/swift-macosx-x86_64/benchmark/logs --swift-repo /Users/mondo/Developer/swift-source/swift --independent-samples  && /Users/mondo/Developer/swift-source/build/Ninja-Release/swift-macosx-x86_64/bin/Benchmark_Driver compare --log-dir /Users/mondo/Developer/swift-source/build/Ninja-Release/swift-macosx-x86_64/benchmark/logs --swift-repo /Users/mondo/Developer/swift-source/swift --compare-script /Users/mondo/Developer/swift-source/swift/benchmark/scripts/compare_perf_tests.py
      usage: Benchmark_Driver run [-h] [-f PATTERN] [-t TESTS] [-o OPT]
                                  [-i INDEPENDENT_SAMPLES] [--output-dir OUTPUT_DIR]
                                  [--swift-repo SWIFT_REPO]
                                  [BENCHMARK [BENCHMARK ...]]
      Benchmark_Driver run: error: argument -i/--independent-samples: expected one argument
      
      ninja: build stopped: subcommand failed.
      

      See also https://forums.swift.org/t/changes-to-how-build-script-runs-benchmarks/18730

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              palimondo Pavol Vaskovic
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated: