Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-96] Investigate devirtualizing super_method #42718

Closed
rudkx opened this issue Dec 6, 2015 · 5 comments
Closed

[SR-96] Investigate devirtualizing super_method #42718

rudkx opened this issue Dec 6, 2015 · 5 comments
Assignees
@swiftix
Labels
compiler The Swift compiler in itself improvement

Comments

@rudkx
Copy link
Member

rudkx commented Dec 6, 2015

Previous ID SR-96
Radar None
Original Reporter @rudkx
Type Improvement
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Improvement
Assignee @swiftix
Priority Medium

md5: 8fddbab15f1b88e373680543efb6ffce

Issue Description:

We do not currently devirtualize super_method. Once the new super_method support is enabled by default we will want to devirtualize these when it is legal.
@rudkx
Copy link
Member Author

rudkx commented Dec 6, 2015

Roman, if you have time to look into this it would be great. Otherwise I'll probably try to look into it when I get a chance.

The new functionality is enabled under -use-native-super-method.

@swiftix
Copy link
Mannequin

swiftix mannequin commented Dec 7, 2015

Looking into it. Adding support for this seems almost trivial, unless I'm missing something. I've implemented this already. Still need to write some tests.

@swiftix
Copy link
Mannequin

swiftix mannequin commented Dec 7, 2015

Committed in d00ec3a and 42fac94

@swiftix
Copy link
Mannequin

swiftix mannequin commented Dec 8, 2015

I think this feature is implemented. The bots are blue.

@bitjammer
Copy link
Member

Roman, you are quick!

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swiftix swiftix

Labels
compiler The Swift compiler in itself improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rudkx @bitjammer