No-vjp mode is not on by default and will soon be deprecated. Please help remove that RUN line. Thanks!

Comment by Gogul Balakrishnan (JIRA)

Even better! Done.

bgogul (JIRA User) Are you removing the "no-vjp-mode" RUN line in a future PR?

I'm wondering because the current version of the test file still has the RUN line:

https://github.com/apple/swift/blob/c5a29ec2bf2f6bb4b3b5cc551863a43fc86df7ad/test/TensorFlowRuntime/tensor_autodiff_runtime.swift

Comment by Gogul Balakrishnan (JIRA)

@dan-zheng, yes, it is removed here just for this file: #21775

@rxwei, should I remove it from all tests?

We are keeping no-vjp mode for optimizations, but I think it might lead to a lot of complications in creating the primal value struct for generic functions: In non-vip mode we have to checkpoint any primal values, and primal values can require indirect passing. Pullbacks will never require indirect passing for primal value structs.
@marcrasi, what do you think?

No need to remove it in your PR bgogul (JIRA User), but it could be pretty good to remove it (and all the novjp code in TFDifferentiation) soon. I left it there so that the code would stay "mostly working" when we decided to start using it again for optimizations, but it seems like it could be quite a burden to keep it working for a while until we start actually using it. It'll probably be easier to delete it all now and bring it back later when we actually need it.