Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-9640] Renable flaky GPU tests in dynamic_attributes.swift #52084

Closed
swift-ci opened this issue Jan 11, 2019 · 1 comment
Closed

[SR-9640] Renable flaky GPU tests in dynamic_attributes.swift #52084

swift-ci opened this issue Jan 11, 2019 · 1 comment
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. swift for tensorflow

Comments

@swift-ci
Copy link
Collaborator

Previous ID SR-9640
Radar None
Original Reporter bgogul (JIRA User)
Type Bug
Status Closed
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Swift for TensorFlow
Labels Bug
Assignee bgogul (JIRA)
Priority Medium

md5: 2da635ebe90703324dbf225b9a13c961

Issue Description:

These tests are flaky because we use expectEqual to compare the results of a conv2D operator. These are disabled in #21775

When I changed expectEqual to expectPointwiseNearlyEqual in dynamic_attributes.swift:246, the compiler crashes.

F0111 12:07:07.683806  233973 logging.cc:80] assert.h assertion failed at /usr/local/google/home/bgogul/workspace/brain/s4tf/llvm/include/llvm/ADT/ArrayRef.h:241 in const T &llvm::ArrayRef<swift::Expr *>::operator[](size_t) const [T = swift::Expr *]: Index < Length && "Inva\
lid index!"
*** Check failure stack trace: ***
    @     0x7f59f8591862  base_logging::LogMessage::SendToLog()
    @     0x7f59f8592063  base_logging::LogMessage::Flush()
    @     0x7f59f8593f95  base_logging::LogMessageFatal::~LogMessageFatal()
    @     0x7f59f858f120  __assert_fail
    @          0x14a8576  swift::constraints::MissingConformanceFailure::diagnoseAsError()
Stack dump:
0.      Program arguments: /usr/local/google/home/bgogul/workspace/brain/s4tf/build/Ninja-ReleaseAssert+stdlib-Release/swift-linux-x86_64/bin/swift -frontend -c -primary-file /usr/local/google/home/bgogul/workspace/brain/s4tf/swift/test/TensorFlowRuntime/dynamic_attributes.\
swift -target x86_64-unknown-linux-gnu -disable-objc-interop -module-cache-path /usr/local/google/home/bgogul/workspace/brain/s4tf/build/Ninja-ReleaseAssert+stdlib-Release/swift-linux-x86_64/swift-test-results/x86_64-unknown-linux-gnu/clang-module-cache -swift-version 4 -O \
-Xllvm -tf-dynamic-compilation -module-name main -o /tmp/lit_tmp_8aqkmn/dynamic_attributes-4e752a.o
1.      While type-checking statement at [/usr/local/google/home/bgogul/workspace/brain/s4tf/swift/test/TensorFlowRuntime/dynamic_attributes.swift:242:1 - line:248:1] RangeText="DynamicAttributeTests.testAllBackends("NormalAttribute String") {
  let result: Tensor<Float> = #tfop("Conv2D", convImage, convFilter,
                                    T$dtype: Float.tensorFlowDataType,
                                    strides: [1, 1, 1, 1] as [Int32],
                                    padding: loadVALIDString())
  expectPointwiseNearlyEqual(convExpectedResult, result.array)
"
2.      While type-checking expression at [/usr/local/google/home/bgogul/workspace/brain/s4tf/swift/test/TensorFlowRuntime/dynamic_attributes.swift:242:1 - line:248:1] RangeText="DynamicAttributeTests.testAllBackends("NormalAttribute String") {
  let result: Tensor<Float> = #tfop("Conv2D", convImage, convFilter,
                                    T$dtype: Float.tensorFlowDataType,
                                    strides: [1, 1, 1, 1] as [Int32],
                                    padding: loadVALIDString())
  expectPointwiseNearlyEqual(convExpectedResult, result.array)
"
3.      While type-checking statement at [/usr/local/google/home/bgogul/workspace/brain/s4tf/swift/test/TensorFlowRuntime/dynamic_attributes.swift:242:65 - line:248:1] RangeText="{
  let result: Tensor<Float> = #tfop("Conv2D", convImage, convFilter,
                                    T$dtype: Float.tensorFlowDataType,
                                    strides: [1, 1, 1, 1] as [Int32],
                                    padding: loadVALIDString())
  expectPointwiseNearlyEqual(convExpectedResult, result.array)
"
@swift-ci
Copy link
Collaborator Author

Comment by Gogul Balakrishnan (JIRA)

#21809 renables the test.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. swift for tensorflow
Projects
None yet
Development

No branches or pull requests

1 participant