You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A number of gyb tests (gyb --test) fail on Windows. It appears it was introduced by commit d57b41e which altered the behaviour of line directives to print paths with forward-slashes even on Windows. Two issues:
1. Doctests involving paths weren't changed to reflect the new behaviour. This breaks the tests that replace the real path with dummy filenames.
2. ExecutionContext.append_path sometimes adds unnecessary line directives. The path normalization occurs in a code branch which does not always execute. The sometimes-normalized path is then recorded in self.last_file_line. When append_text is later invoked, it (incorrectly) compares the sometimes-normalized path in self.last_file_line with the non-normalized file argument.
The text was updated successfully, but these errors were encountered:
Additional Detail from JIRA
md5: e34c3b1fa6b147aa0753e723bfca9b51
Parent-Task:
Issue Description:
A number of gyb tests (
gyb --test
) fail on Windows. It appears it was introduced by commit d57b41e which altered the behaviour of line directives to print paths with forward-slashes even on Windows. Two issues:1. Doctests involving paths weren't changed to reflect the new behaviour. This breaks the tests that replace the real path with dummy filenames.
2. ExecutionContext.append_path
sometimes adds unnecessary line directives. The path normalization occurs in a code branch which does not always execute. The sometimes-normalized path is then recorded inself.last_file_line
. Whenappend_text
is later invoked, it (incorrectly) compares the sometimes-normalized path inself.last_file_line
with the non-normalizedfile
argument.The text was updated successfully, but these errors were encountered: