Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-9644] GYB errors on Windows due to path normalization #52088

Closed
swift-ci opened this issue Jan 12, 2019 · 2 comments
Closed

[SR-9644] GYB errors on Windows due to path normalization #52088

swift-ci opened this issue Jan 12, 2019 · 2 comments

Comments

@swift-ci
Copy link
Collaborator

Previous ID SR-9644
Radar None
Original Reporter lynnk (JIRA User)
Type Sub-task
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Project Infrastructure
Labels Sub-task
Assignee None
Priority Medium

md5: e34c3b1fa6b147aa0753e723bfca9b51

Parent-Task:

Issue Description:

A number of gyb tests (gyb --test) fail on Windows. It appears it was introduced by commit d57b41e which altered the behaviour of line directives to print paths with forward-slashes even on Windows. Two issues:

1. Doctests involving paths weren't changed to reflect the new behaviour. This breaks the tests that replace the real path with dummy filenames.

2. ExecutionContext.append_path sometimes adds unnecessary line directives. The path normalization occurs in a code branch which does not always execute. The sometimes-normalized path is then recorded in self.last_file_line. When append_text is later invoked, it (incorrectly) compares the sometimes-normalized path in self.last_file_line with the non-normalized file argument.

@swift-ci
Copy link
Collaborator Author

Comment by Lynn Kirby (JIRA)

See pull request at #21816.

@belkadan
Copy link
Contributor

cc @compnerd

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants