Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-9681] [AD] Change @_fieldwiseProductSpace to an attribute on the parent decl. #52124

Closed
rxwei opened this issue Jan 16, 2019 · 1 comment
Closed

[SR-9681] [AD] Change @_fieldwiseProductSpace to an attribute on the parent decl. #52124

rxwei opened this issue Jan 16, 2019 · 1 comment
Assignees
@rxwei
Labels
improvement swift for tensorflow

Comments

@rxwei
Copy link
Member

rxwei commented Jan 16, 2019

Previous ID SR-9681
Radar None
Original Reporter @rxwei
Type Improvement
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Swift for TensorFlow
Labels Improvement
Assignee @rxwei
Priority Medium

md5: 17acf35ea5ed51be70249f32b355fe52

Issue Description:

After derived conformances @_fieldwiseProductSpace either exists on all Tangent/Cotangent/AllDifferentiableVariables or not at all. So it should really be an attribute on the parent decl. And this will simplify the code for checking that quite a lot.
@rxwei
Copy link
Member Author

rxwei commented Jan 27, 2019

Switched to a new decl attribute `@_fieldwiseDifferentiable`. #22009

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rxwei rxwei

Labels
improvement swift for tensorflow
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rxwei