Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-10192] value witness(es) for {get,store}SingleEnumTagPayload are emitted without COMDAT in some cases #52592

Closed
compnerd opened this issue Mar 27, 2019 · 4 comments
Closed

[SR-10192] value witness(es) for {get,store}SingleEnumTagPayload are emitted without COMDAT in some cases #52592

compnerd opened this issue Mar 27, 2019 · 4 comments
Assignees
@compnerd
Labels
compiler The Swift compiler in itself

Comments

@compnerd
Copy link
Collaborator

Previous ID SR-10192
Radar None
Original Reporter @compnerd
Type Sub-task
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Sub-task
Assignee @compnerd
Priority Medium

md5: 7b98e70ddd258552c786b9661917bb43

Parent-Task:

Issue Description:

This appears to happen with the release build of Foundation causing multiply defined symbols.
@belkadan
Copy link
Contributor

I don't think these are supposed to be multiply emitted in the first place, unless they're for imported enums. Which wouldn't need these value witnesses.

@compnerd
Copy link
Collaborator Author

@belkadan - the enums are imported, but they have an extension associated with them which is why we are emitting these. Who would be something to talk to about this? This is a bug in the optimization path where we try to fold away the function body.

@belkadan
Copy link
Contributor

@jckarter or @rjmccall, maybe? I'm probably just misunderstanding the purpose of these value witnesses.

@compnerd
Copy link
Collaborator Author

apple/swift-llvm#153

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@compnerd compnerd

Labels
compiler The Swift compiler in itself
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@compnerd @belkadan