Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-10536] update-checkout gives useless spew if git clone fails or it's not in a checkout #52936

Open
rjmccall opened this issue Apr 22, 2019 · 0 comments
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself update-checkout Area → utils: the `update-checkout` script

Comments

@rjmccall
Copy link
Member

Previous ID SR-10536
Radar None
Original Reporter @rjmccall
Type Bug
Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Bug, UpdateCheckout
Assignee None
Priority Medium

md5: 343b94f6b2614a0d4122a502c9976a97

Issue Description:

I've noticed in the past that update-checkout gives terrible "diagnostics" if `git clone` fails: basically, it just crashes and lets Python print its normal exception stacktrace, which is really difficult to find useful information in (even for me, much less someone who doesn't know what to look for). It also seems to fail quite badly if it's not in a checkout directory, e.g. if someone's trying to build from a source tarball; we don't necessarily need to support that, but we should give more useful feedback than a Python exception.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself update-checkout Area → utils: the `update-checkout` script
Projects
None yet
Development

No branches or pull requests

1 participant