Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-10579] Change PlatformKind::OSX to PlatformKind::macOS #52979

Closed
beccadax opened this issue Apr 29, 2019 · 3 comments
Closed

[SR-10579] Change PlatformKind::OSX to PlatformKind::macOS #52979

beccadax opened this issue Apr 29, 2019 · 3 comments
Labels
compiler The Swift compiler in itself good first issue Good for newcomers task

Comments

@beccadax
Copy link
Contributor

Previous ID SR-10579
Radar rdar://problem/55094716
Original Reporter @beccadax
Type Task
Status Closed
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Task, StarterBug
Assignee alberto.lagos (JIRA)
Priority Medium

md5: 01de60e7f0a57c1fbb96393d5c8c9ef4

Issue Description:

We are increasingly treating "macOS" as the canonical name of the Apple desktop/notebook platform and "OS X" as a backwards-compatibility alias. For example, in SE-0106 we introduced "macOS" as an alias for "OS X" in Swift source, and in apple/swift#24334 we will change error messages to refer to "macOS" instead of "OS X". However, internally the compiler still thinks of this platform as "PlatformKind::OSX" and "macOS" as just a funny alias for it; getting it to produce "macOS" instead of "OSX" in various circumstances requires special exceptions.

We should reverse the polarity here by making "macOS" the real name of the platform and "OSX" the alias. But we should probably delay this until a point where we don't have a release branch to keep in sync to avoid unnecessary pain.
@swift-ci
Copy link
Collaborator

swift-ci commented Jun 3, 2020

Comment by Alberto Lagos (JIRA)

brentdax (JIRA User) I would like to take this ticket, this is my second ticket for swift. Any suggestion on how to tackle this?. I suppose that i need to start in lib/Basic/LangOptions.cpp

Thanks!

@swift-ci
Copy link
Collaborator

Comment by Alberto Lagos (JIRA)

I believe that this was fixed by @nathawes ( commit )

I think that we can close this.

@compnerd
Copy link
Collaborator

Fixed by 244dc4a

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler The Swift compiler in itself good first issue Good for newcomers task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@compnerd @beccadax @swift-ci