[SR-10654] fix @convention(thin) #53054
Labels
bug
A deviation from expected or documented behavior. Also: expected but undesirable behavior.
compiler
The Swift compiler in itself
performance
Comments
|
I view this as a way of achieving at declaration-site what https://bugs.swift.org/browse/SR-10653 achieves on use-site, allowing to make sure I won't close over things. I agree with Johannes that knowing that I won't close over things is a tremendously useful thing in high performance code – esp. if closure heavy, though all the closures should be just pure functions from their input to some output (think streaming operators, stateful transformations (like "pure" map(), filter() or similar)). |
|
cc @jckarter |
|
@swift-ci create |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Additional Detail from JIRA
md5: ea8563aaed5377e6126d8a792b6ac7da
Issue Description:
@convention(thin)is often very useful in high-performance code (to save a word, and ARC traffic. Unfortunately@conventin(thin)doesn't actually work and apparently can lead to miscompiles.We should fix it.
See here on why this is a useful construct in high-perf code: https://forums.swift.org/t/use-of-convention-thin-to-avoid-allocating-closures/12087
The text was updated successfully, but these errors were encountered: