Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-10945] Swift Package Manager manifest's SwiftLanguageVersion should have a v5_1 case #4695

Closed
jpsim opened this issue Jun 16, 2019 · 1 comment
Closed

[SR-10945] Swift Package Manager manifest's SwiftLanguageVersion should have a v5_1 case #4695

jpsim opened this issue Jun 16, 2019 · 1 comment
Labels
bug

Comments

@jpsim
Copy link
Contributor

jpsim commented Jun 16, 2019

Previous ID SR-10945
Radar None
Original Reporter @jpsim
Type Bug
Status Resolved
Resolution Invalid
Additional Detail from JIRA
Votes 0
Component/s Package Manager
Labels Bug
Assignee None
Priority Medium

md5: e19c36c11aaab414f18f0b1361098625

Issue Description:

In order for Swift packages that require Swift 5.1 or later to coexist with packages that require Swift 5.0 or later, the Swift Package Manager's SwiftLanguageVersion enum should add a v5_1 case.

The existing values are v3, v4, v4_2 and v5.

swift-package-manager/Sources/PackageModel/ToolsVersion.swift

Lines 126 to 144 in e2084ae

/// Represents a Swift language version.
public struct SwiftLanguageVersion: CustomStringConvertible, Comparable {
/// Swift language version 3.
public static let v3 = SwiftLanguageVersion(uncheckedString: "3")
/// Swift language version 4.
public static let v4 = SwiftLanguageVersion(uncheckedString: "4")
/// Swift language version 4.2.
public static let v4_2 = SwiftLanguageVersion(uncheckedString: "4.2")
/// Swift language version 5.
public static let v5 = SwiftLanguageVersion(uncheckedString: "5")
/// The list of known Swift language versions.
public static let knownSwiftLanguageVersions = [
v3, v4, v4_2, v5,
]

@ankitspd
Copy link
Member

There’s no Swift 5.1 language mode. If you want to require Swift 5.1 compiler, just set the tools version to 5.1

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 4, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jpsim @ankitspd