[SR-11434] False positive warning: cast always fails from 'Encodable' to 'NSDecimalNumber'/'[String: Encodable]' #53835
Labels
compiler
The Swift compiler in itself
Comments
|
Tagging both Compiler and Foundation until someone investigates to decide who's wrong. |
|
The compiler is wrong. Someone just fixed something in this area…@theblixguy, do you remember who it was? |
|
I did recently tweaked the code around casts from a protocol type to a non-protocol type, but my change disabled the diagnostic for situations when we're casting from a protocol type to a non-final class (see #26971), so the first diagnostic should not be produced anymore. |
|
Okay, so this is probably "continues to be broken" rather than "was recently broken". |
|
@stephentyrone this is fixed on master, can you please verify on the next available snapshot and close? Thanks 🙂 |
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Additional Detail from JIRA
md5: 8b7ddb293d9ac1d4acfdae5edc9c5230
Parent-Task:
Issue Description:
Observed on fairly recent master:
/Volumes/Data/Checkouts/Swift/swift/stdlib/public/Darwin/Foundation/JSONEncoder.swift:928:27: warning: cast from 'Encodable' to unrelated type 'NSDecimalNumber' always fails
return (value as! NSDecimalNumber)
~~~~~ ^ ~~~~~~~~~~~~~~~
/Volumes/Data/Checkouts/Swift/swift/stdlib/public/Darwin/Foundation/JSONEncoder.swift:930:39: warning: cast from 'Encodable' to unrelated type '[String : Encodable]' always fails
return try self.box(value as! [String : Encodable])
~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~
Either the warning is wrong, or this is a bug in the overlay.
The text was updated successfully, but these errors were encountered: