Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-1174] [llbuild] Properly escape verbose command descriptions #806

Closed
ddunbar opened this issue Apr 7, 2016 · 1 comment
Closed

[SR-1174] [llbuild] Properly escape verbose command descriptions #806

ddunbar opened this issue Apr 7, 2016 · 1 comment

Comments

@ddunbar
Copy link
Member

ddunbar commented Apr 7, 2016

Previous ID SR-1174
Radar None
Original Reporter @ddunbar
Type Bug
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s llbuild
Labels Bug, StarterBug
Assignee @aciidb0mb3r
Priority Medium

md5: 9e2bc2a22e36a68f65cc008d340149b7

Issue Description:

llbuild has a number of places where it prints out a command line to the console. When doing so, we should quote the command such that it will execute properly if rerun from the shell, which requires performing shell escaping.

For example:

$ cat t.llbuild 
client:
  name: basic
  version: 0

targets:
  "": ["<dummy>"]

commands:
  C.dummy:
    tool: shell
    args: ["echo", "hello \"world\"!"]
    outputs: ["<dummy>"]

$ llbuild buildsystem build --no-db -f t.llbuild 
echo "hello "world"!"
hello "world"!

The first command printed there echo "hello "world"!" is not escaped properly.

@ankitspd
Copy link
Member

ankitspd commented May 6, 2016

#29

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 5, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants