Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-11803] Don't inject "willThrow" hooks before rethrow propagation branches #54213

Closed
CodaFi opened this issue Nov 18, 2019 · 3 comments
Closed

[SR-11803] Don't inject "willThrow" hooks before rethrow propagation branches #54213

CodaFi opened this issue Nov 18, 2019 · 3 comments
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself good first issue Good for newcomers

Comments

@CodaFi
Copy link
Member

CodaFi commented Nov 18, 2019

Previous ID SR-11803
Radar None
Original Reporter @CodaFi
Type Bug
Status Closed
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Bug, StarterBug
Assignee mkita (JIRA)
Priority Medium

md5: 5bcb9cad814df2dd1cc8124f822c3e34

Issue Description:

LLDB has a magic symbol it's looking for in order to implement Swift exception breakpoints. That symbol is "willThrow" in SIL and it's implemented with "swift_willThrow" in IRGen. The trouble is that we're a little too aggressive about emitting calls to this hook. Joe has already identified the places we don't need it in #13585

Step one is to take that PR, rebase it, and rerun the tests to make sure everything is good. The real task is to take that pull request and do the opposite where we propagate Objective-C errors into Swift. The logic for this sits in SILGenForeignError.cpp. There should also be an IRGen test to make sure we emit the right set of branches, cleanups, and error propagation code.
@CodaFi
Copy link
Member Author

CodaFi commented Nov 18, 2019

A rare SILGen/IRGen starter bug!

@swift-ci
Copy link
Collaborator

Comment by Maksim Kita (JIRA)

I would like to fix this problem.

@swift-ci
Copy link
Collaborator

swift-ci commented Dec 4, 2019

Comment by Maksim Kita (JIRA)

#28455

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@CodaFi @swift-ci