Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-11852] [AutoDiff] emitBuiltinAutoDiffApplyDerivativeFunction should not worry about curry levels #54258

Closed
rxwei opened this issue Nov 25, 2019 · 3 comments
Closed

[SR-11852] [AutoDiff] emitBuiltinAutoDiffApplyDerivativeFunction should not worry about curry levels #54258

rxwei opened this issue Nov 25, 2019 · 3 comments
Assignees
@marcrasi
Labels
AutoDiff compiler The Swift compiler in itself improvement

Comments

@rxwei
Copy link
Member

rxwei commented Nov 25, 2019

Previous ID SR-11852
Radar None
Original Reporter @rxwei
Type Improvement
Status Closed
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Improvement, AutoDiff
Assignee @marcrasi
Priority Medium

md5: ad9d57b4a2fa3e3dd693fa79e542be64

Issue Description:

The emitBuiltinAutoDiffApplyDerivativeFunction function in SILGenBuiltin.cpp needs to be cleaned up. It seems to have some dead code (added in December 2018) that unwraps curry levels. Curry-level unwrapping for @differentiable functions was originally added as a workaround – it's no longer necessary.
@rxwei
Copy link
Member Author

rxwei commented Nov 25, 2019

@marcrasi Are you interested in helping clean this up?

@marcrasi
Copy link
Mannequin

marcrasi mannequin commented Nov 25, 2019

Yes, seems fun to clean up 🙂

@dan-zheng
Copy link
Collaborator

Done in #30622.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcrasi marcrasi

Labels
AutoDiff compiler The Swift compiler in itself improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rxwei @dan-zheng