Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-12122] Misleading error message with swift package compute-checksum #4613

Closed
ryanwilson opened this issue Feb 3, 2020 · 5 comments
Closed

Comments

@ryanwilson
Copy link
Contributor

Previous ID SR-12122
Radar rdar://problem/59132845
Original Reporter @ryanwilson
Type Improvement
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Package Manager
Labels Improvement
Assignee None
Priority Medium

md5: 203443e07accd3760f82af10bd11c916

Issue Description:

After playing around with binary frameworks, I tried to use the `compute-checksum` command on an `xcframework` directory. The resulting error printed was:

"file not found at path: <my_path>"

I was a bit confused and double-checked the path exists before realizing it was expecting a file and not the directory.

Since it may be common to pass in an `xcframework` here, I propose adding a small diagnostic giving a hint that a `zip` file is expected.

I have a small commit that implements this at db17270 and I'm happy to open a PR if that's desired and a proper way forward.

Thanks!

@ankitspd
Copy link
Member

ankitspd commented Feb 3, 2020

cc @hartbit

@ankitspd
Copy link
Member

ankitspd commented Feb 3, 2020

@ryanwilson Awesome, I see that you have a suggested fix already. Can you open a PR on SwiftPM?

@ryanwilson
Copy link
Contributor Author

It would be my pleasure 😃 thanks for the fast reply!

@ryanwilson
Copy link
Contributor Author

Started as a draft while I build and verify locally: #2544

@beccadax
Copy link
Contributor

beccadax commented Feb 4, 2020

@swift-ci create

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 4, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants