Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-12245] api-digester: (probably) bogus "Func NIOSSLError.==(_:_:) has been removed" #54672

Open
weissi opened this issue Feb 20, 2020 · 2 comments
Open

[SR-12245] api-digester: (probably) bogus "Func NIOSSLError.==(_:_:) has been removed" #54672

weissi opened this issue Feb 20, 2020 · 2 comments
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior.

Comments

@weissi
Copy link
Member

weissi commented Feb 20, 2020

Previous ID SR-12245
Radar rdar://problem/59627996
Original Reporter @weissi
Type Bug
Additional Detail from JIRA
Votes 0
Component/s Source Tooling
Labels Bug
Assignee None
Priority Medium

md5: f611dd2a5f7cea398d7e5c795476387e

Issue Description:

API digester says that removing a manual == and replacing it by the synthesised one is API breaking: This PR

https://github.com/apple/swift-nio-ssl/pull/186/files

lead to

10:35:30 Checking NIOSSL.json... ERROR
10:35:30 ==============================
10:35:30 ERROR: public API change in NIOSSL.json
10:35:30 ==============================
10:35:30 
10:35:30 /* Generic Signature Changes */
10:35:30 
10:35:30 /* RawRepresentable Changes */
10:35:30 
10:35:30 /* Removed Decls */
10:35:30 Func NIOSSLError.==(_:_:) has been removed
10:35:30 
10:35:30 /* Moved Decls */
10:35:30 
10:35:30 /* Renamed Decls */
10:35:30 
10:35:30 /* Type Changes */
10:35:30 
10:35:30 /* Decl Attribute changes */
10:35:30 
10:35:30 /* Fixed-layout Type Changes */
10:35:30 
10:35:30 /* Protocol Conformance Change */
10:35:30 
10:35:30 /* Protocol Requirement Change */
10:35:30 
10:35:30 /* Class Inheritance Change */
10:35:30 done
@weissi
Copy link
Member Author

weissi commented Feb 20, 2020

@swift-ci create

@weissi
Copy link
Member Author

weissi commented Feb 20, 2020

CC @xwu

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@weissi