Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-12987] [build] Apple and ELF linker flags for the stdlib dropped since Catalyst was added #55433

Open
finagolfin opened this issue Jun 12, 2020 · 0 comments
Labels
standard library Area: Standard library umbrella task

Comments

@finagolfin
Copy link
Contributor

Previous ID SR-12987
Radar None
Original Reporter @buttaface
Type Task
Additional Detail from JIRA
Votes 0
Component/s Standard Library
Labels Task
Assignee None
Priority Medium

md5: 21905cba10b8d2b6c0c90d0ecbab87ea

Issue Description:

The stdlib CMake config defines a local variable `swiftlib_link_flags_all`, then adds some link flags for Apple platforms and ELF platforms. However, a recent single-line change resets that variable and drops those flags, added with the Catalyst changes in January.

I notified the author of that pull (never got a response to multiple pings on github) and got a pull merged that reverted that single line reset in April, but that was quickly reverted because of "an internal CI failure" at Apple, presumably why the Catalyst pull dropped these flags in the first place.

Someone needs to go through and figure out which of these linker flags are still needed and correct this now dead code. Not going to be me, as I can't even get these Apple engineers to respond to me.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
standard library Area: Standard library umbrella task
Projects
None yet
Development

No branches or pull requests

1 participant