Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-13379] stdlib-asserts Performance regression from swift_COWSanityChecksEnabled #55819

Open
atrick opened this issue Aug 10, 2020 · 1 comment
Open

[SR-13379] stdlib-asserts Performance regression from swift_COWSanityChecksEnabled #55819

atrick opened this issue Aug 10, 2020 · 1 comment
Assignees
@eeckstein
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. standard library Area: Standard library umbrella

Comments

@atrick
Copy link
Member

atrick commented Aug 10, 2020

Previous ID SR-13379
Radar rdar://problem/66803778
Original Reporter @atrick
Type Bug
Additional Detail from JIRA
Votes 0
Component/s Standard Library
Labels Bug
Assignee @eeckstein
Priority Medium

md5: ee48d30c9eb2c391f573ba9cde4e1250

cloned from:

  • SR-13375 Performance regression on master: swift_COWSanityChecksEnabled

Issue Description:

The performance regression was reported here:

https://bugs.swift.org/browse/SR-13375

That issue will be fixed by building without stdlib asserts, but the problem remains. It can be fixed by checking if COW checks are enabled using a swift_once call instead of querying the OS environment each time.
@atrick
Copy link
Member Author

atrick commented Aug 10, 2020

@swift-ci create

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eeckstein eeckstein

Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. standard library Area: Standard library umbrella
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@atrick