Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-13573] Fix Spelling of CustomReflecatbleTests.swift #406

Closed
swift-ci opened this issue Sep 20, 2020 · 5 comments
Closed

[SR-13573] Fix Spelling of CustomReflecatbleTests.swift #406

swift-ci opened this issue Sep 20, 2020 · 5 comments
Labels
bug Something isn't working

Comments

@swift-ci
Copy link
Contributor

Previous ID SR-13573
Radar None
Original Reporter vermont42 (JIRA User)
Type Bug
Status Closed
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s SwiftSyntax
Labels Bug, StarterBug
Assignee maldahleh (JIRA)
Priority Medium

md5: 5c5fbcce6fac68b0b37280cd0bede337

Issue Description:

While implementing SR-11580, I noticed that the filename CustomReflecatbleTests.swift is misspelled. This is a perfect starter bug. The only steps to fix it are to correct the filename and ensure that SwiftSyntax unit tests still pass.

I myself am a newcomer to compiler development, so the following build-script invocation may be suboptimal, but it should work to build Swift and SwiftSyntax (if necessary) and run the SwiftSyntax unit tests. Run this from the parent folder of swift and swift-syntax. Build-and-test output will go to ~/Desktop/allout.txt.

time swift/utils/build-script --swiftsyntax --swiftpm --llbuild -t --skip-test-cmark --skip-test-swift --skip-test-llbuild --skip-test-swiftpm --infer > ~/Desktop/allout.txt 2>&1

I got build errors before adding the --infer argument, and I am unclear why it is not the default.
@typesanitizer
Copy link

> I got build errors before adding the --infer argument, and I am unclear why it is not the default.

It's a new option, so it's "experimental" for now. I don't know if there are more issues that need to be worked out, it works OK for me. cc @gottesmm

@swift-ci
Copy link
Contributor Author

Comment by Josh Adams (JIRA)

Thanks for the context, Varun. Likely a quirk in my environment causes `--infer` to be necessary for me.

@typesanitizer
Copy link

In this particular case, I think it needs --install-llbuild and --install-swiftpm and maybe even --swift-driver and --install-swift-driver, and then using it without --infer should work.

@swift-ci
Copy link
Contributor Author

swift-ci commented Oct 9, 2020

Comment by Mohammed Al-Dahleh (JIRA)

I'm interested in trying this out

@swift-ci
Copy link
Contributor Author

Comment by Mohammed Al-Dahleh (JIRA)

Fixed with #245

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 9, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@typesanitizer @swift-ci