[SR-13848] Restore Note About Optionality Mismatch in Redeclared Functions Involving IUOs and Optionals #56246
Labels
bug
A deviation from expected or documented behavior. Also: expected but undesirable behavior.
compiler
The Swift compiler in itself
diagnostics QoI
Bug: Diagnostics Quality of Implementation
good first issue
Good for newcomers
type checker
Area → compiler: Semantic analysis
Comments
|
Hello @CodaFi, I'm new here and trying to find something easy to get acquainted with the process. Please correct me when I'm wrong. Essentially the new func optionalInOut(x: inout Int!) { } // expected-error{{invalid redeclaration of 'optionalInOut(x:)}}should also include the note which differs only by the kind of optional passed as an inout argument ('Int!' vs. 'Int?')Like it used to for the warning before this commit? |
|
Yes, that’s the idea. |
|
Resolved by the merge of #34823 |
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Additional Detail from JIRA
md5: 1147b9bfe76cf8f9a6a7fd5065ba6139
Issue Description:
We currently consider functions that attempt to overload with an implicitly unwrapped optional and a plain optional to be redeclarations of each other and emit an error
There used to be a note in Swift 4.1 about how these redeclarations only differed in optionality, but it was removed here f088237
We should really add it back, it was helpful.
The text was updated successfully, but these errors were encountered: